feat: set 'jetbrains_connection' as build reason on workspace start #150
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fioan89
requested changes
Jul 15, 2025
| import com.squareup.moshi.Json | ||
|
|
||
| enum class WorkspaceBuildReason { | ||
| @Json(name = "jetbrains_connection") JETBRAINS_CONNECTION, |
There was a problem hiding this comment.
Toolbox plugin polls every 5 seconds the workspaces, which means in theory we will have to deserialized the other possible values otherwise I think a JsonDataException will be raised. I'd have to test it... but I think that's what moshi will do.
There was a problem hiding this comment.
This enum is only used by CreateWorkspaceBuildRequest and only applies when starting a workspace.
There was a problem hiding this comment.
So you mean if I start a workspace from vs code, Toolbox will never receive the workspace build reason while polling, do I get that right?
fioan89
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of coder/coder#18827 which introduces new build reason values to identify what type of connection triggered a workspace build, helping to troubleshoot workspace-related issues.