chore: remove ssh background config #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing, Toolbox forwards through SSH (i.e. through Coder) a remote port associated with the IDE
running in server mode, to localhost in order for the server (i.e. the remote IDE) to communicate with
JBClient. Unlike with Gateway, Toolbox manages to reuse the SSH connection, and it doesn't open a separate
one for port forwarding.
From Gateway we inherited two ssh hostnames per each workspace, one for background connections that did not
involve running IDEs. Coder discards the bg. connection from the collected metrics in order to
avoid double counting. Since Toolbox manages to re-use the connection we don't need to worry
about double counting.
For this particular change, I deployed the latest Coder version with prometheus metrics and experiments
enabled (i.e. --prometheus-enable --prometheus-collect-agent-stats --experiments=workspace-usage) and made the following experiment:
Hit the install button on RustRover, everything stayed unchanged
Open RustRover, nothing changes in the stats.