Skip to content

fix: fix build.sh script #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: fix build.sh script #59

merged 1 commit into from
Jul 30, 2024
+1 −1

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 30, 2024 •
edited
Loading

Fixes a lame typo.
shellcheck missed this.

@matifali matifali requested a review from johnstcn July 30, 2024 09:42
@matifali matifali self-assigned this Jul 30, 2024
@matifali
Copy link
Member Author

@johnstcn to test it should we reuse(delete and push) tag v0.0.11-rc.0 or push a new one v0.0.11-rc.1

@johnstcn
Copy link
Member

@johnstcn to test it should we reuse(delete and push) tag v0.0.11-rc.0 or push a new one v0.0.11-rc.1

I would recommend pushing a new tag.

@matifali matifali merged commit c390e75 into main Jul 30, 2024
1 check passed
@matifali matifali deleted the matifali-patch-1 branch July 30, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @johnstcn