chore: improve release workflow #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
requested review from
johnstcn and
kylecarbs
and removed request for
johnstcn
This should handle uploading asset to existing release when releases are created manually.
johnstcn
reviewed
Jul 30, 2024
johnstcn
reviewed
Jul 30, 2024
|
tested script to publish https://github.com/coder/coder-logstream-kube/releases/tag/v0.0.11-rc.1 |
johnstcn
reviewed
Jul 31, 2024
| if gh release view $version; then | ||
| echo "Release $version already exists" | ||
| exit 0 | ||
| else |
There was a problem hiding this comment.
nit: can remove else case and outdent below block due to exit 0
There was a problem hiding this comment.
I also discovered that the gh release view is interactive and ensured it could run noninteractively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things.
rctags are marked as latest. I saw this withv0.0.11-rc.1.gh release create.