Skip to content

docs: align CODER_HTTP_ADDRESS with document #10779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2023
Merged

docs: align CODER_HTTP_ADDRESS with document #10779

merged 1 commit into from
Nov 19, 2023

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Nov 19, 2023 •
edited
Loading

related #6228

coder/docs/admin/configure.md

Line 142 in cfe35f5

CODER_HTTP_ADDRESS=0.0.0.0:3000

Actually these two environment variables are really confusing to me.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Nov 19, 2023
@github-actions GitHub Actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

kylecarbs
kylecarbs approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODER_ADDRESS is deprecated anyways!

@kylecarbs kylecarbs enabled auto-merge (squash) November 19, 2023 15:35
@JounQin
Copy link
Contributor Author

JounQin commented Nov 19, 2023

https://github.com/search?q=repo%3Acoder%2Fcoder%20CODER_ADDRESS&type=code

@kylecarbs There seems are many legacy CODER_ADDRESS used, should we update them at the same time?

@kylecarbs kylecarbs merged commit 9b864ed into coder:main Nov 19, 2023
@JounQin
Copy link
Contributor Author

JounQin commented Nov 19, 2023

I have read the CLA Document and I hereby sign the CLA

@kylecarbs
Copy link
Member

@JounQin seems reasonable to me!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
@JounQin JounQin deleted the patch-1 branch November 19, 2023 15:39
@kylecarbs
Copy link
Member

@JounQin oops, this auto-merged. Toss up another PR and I'll approve!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@JounQin JounQin

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JounQin @kylecarbs