Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto add flags docs into the README #147

Merged
merged 4 commits into from
Apr 29, 2024
Merged

feat: auto add flags docs into the README #147

merged 4 commits into from
Apr 29, 2024

Conversation

BrunoQuaresma
Copy link
Contributor

@BrunoQuaresma BrunoQuaresma commented Apr 25, 2024

I still need to make it run on CI and add it to Makefile but I would appreciate an early review of the code.

You can see a preview of the generated docs here: https://github.com/coder/envbuilder/blob/cd219d378179f0861903190dcd66c117dcc8dd68/README.md#environment-variables

Strategy
I added some markers, as HTML comments, in the markdown so the script can know where to place/replace the new content. Another option is to create another markdown file only for the flags and mention it on the main README.

Close #130

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 25, 2024
README.md Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
scripts/docsgen/main.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/docsgen/main.go Outdated Show resolved Hide resolved
scripts/docsgen/main.go Outdated Show resolved Hide resolved
@BrunoQuaresma
Copy link
Contributor Author

BrunoQuaresma commented Apr 26, 2024

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
Base automatically changed from bq/docs to main April 29, 2024 13:20
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review April 29, 2024 13:36
@BrunoQuaresma BrunoQuaresma merged commit 6218976 into main Apr 29, 2024
5 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/cli-gen branch April 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autogenerate docs for all envbuilder flags
5 participants