Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: warn if docker secret cleanup fails #163

Merged
merged 3 commits into from
May 1, 2024
Merged

chore: warn if docker secret cleanup fails #163

merged 3 commits into from
May 1, 2024

Conversation

BrunoQuaresma
Copy link
Contributor

Closes #159

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 30, 2024
johnstcn
johnstcn reviewed Apr 30, 2024
View reviewed changes
envbuilder.go Outdated Show resolved Hide resolved
envbuilder.go Show resolved Hide resolved
envbuilder.go Show resolved Hide resolved
@johnstcn
Copy link
Member

johnstcn commented May 1, 2024

I think this might also be a good place to add a check in the integration tests that the docker config.json was removed, something like this might work:

		statOutput := execContainer(t, ctr, "stat "+filepath.Join(envbuilder.MagicDir, "config.json"))
		require.Contains(t, statOutput, "No such file or directory")

@BrunoQuaresma BrunoQuaresma requested a review from johnstcn May 1, 2024 16:07
@BrunoQuaresma BrunoQuaresma merged commit ff220b4 into main May 1, 2024
4 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/cleanup-warning branch May 1, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn if clean up does not work when removing Docker config file.
2 participants
@BrunoQuaresma @johnstcn