Use a deterministic target path for feature dir mounts with useBuildContexts #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
force-pushed
the
deterministic-path
branch
from
8e3f287
to
ee5a4f9
Compare
kylecarbs
reviewed
Jun 24, 2024
…ontexts This avoids caching issues when using the Dockerfile produced in useBuildContexts mode. See coder#205 (comment) for context.
aaronlehmann
force-pushed
the
deterministic-path
branch
from
ee5a4f9
to
93423f5
Compare
|
Works for me! I've changed the prefix to |
|
I think duplicating it is fine! |
kylecarbs
approved these changes
Jun 24, 2024
|
@aaronlehmann feel free to merge whenever! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids caching issues when using the Dockerfile produced in
useBuildContextsmode. See#205 (comment) for context.