fix(remount): relocate libraries along with their symlinks #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
Jul 1, 2024
johnstcn
reviewed
Jul 1, 2024
johnstcn
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Thank you for this contribution!
I validated this fix on a Fedora 40 system with the NVidia runtime etc. installed (so no /usr/lib/x86_64-linux-gnu), using both Docker (v27.0.2) and K3s (v1.29.6).
(Edit: for posterity, also verified working on an AL2 EKS cluster.)
In both cases, I was able to successfully build the image nvcr.io/nvidia/k8s/cuda-sample:vectoradd-cuda10.2, run nvidia-smi and /tmp/vectorAdd.
My only things I would like to see changed are:
- More commenting for future readers/code-spelunkers
- Remove references to PPC arch; I don't know if we will ever support this.
There may also be a similar workaround needed for AMD/Vulkan cards, but this can be tested separately.
maxbrunet
force-pushed
the
fix/remount/relocate-libs
branch
from
0997cbd to
07d0f1c
Compare
johnstcn
pushed a commit
that referenced
this pull request
Jul 5, 2024
(cherry picked from commit 46a78fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
After that the container should behave like a regular container created by the NVIDIA container runtime. Of course/unfortunately, the process of mounting/unmounting requires GPU containers to run with privileges:
https://www.man7.org/linux/man-pages/man2/mount.2.html
https://www.man7.org/linux/man-pages/man2/umount.2.html
The logic is not generalized to any symlinks or any directories, it only aims at providing compatibility with the NVIDIA container runtime for now.
More context can be found in this comment #143 (comment)
Tested with the following images:
docker.io/library/debian:bookwormdocker.io/library/fedora:40nvcr.io/nvidia/pytorch:24.05-py3Closes #143