fix: add preExec to Run #368
Merged
+84
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
changed the title
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
johnstcn
added a commit
that referenced
this pull request
Sep 27, 2024
Fixes #364 Adds the capability for Run() to run defers defined outside of Run(). Currently the only use-case for this is to close the Coder logger. Also adds an integration test that validates this behaviour and ensures that closeLogs gets called. Co-authored-by: Mathias Fredriksson <mafredri@gmail.com> (cherry picked from commit 481e3a9)
johnstcn
added a commit
that referenced
this pull request
Sep 27, 2024
johnstcn
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364
Adds the capability for
Run()to run defers defined outside ofRun().Currently the only use-case for this is to close the Coder logger.
Also adds an integration test that validates this behaviour and ensures that
closeLogsgets called.