-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ssh access to git repository #92
Conversation
- Build-in (or mount) private key in envbuilder image for access repository
Co-authored-by: Aaron Lehmann <aaronl@vitelus.com>
Parse first layer of path to find valid private key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some commits for fix/improve some problems according to comment message.
@@ -147,6 +148,41 @@ resource "docker_container" "dev" { | |||
} | |||
``` | |||
|
|||
### PrivateKey-based authentication | |||
* Prebuild private key in your envbuilder image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this dangerous if we use a cache registry ?
The layer containing the private key may end up in the registry, or am I missing something ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original assumption was that this image may be stored in a private registry, so I didn't take into consideration the potential issue of having a private key in the image layers.
Is there any other way as of right now to clone a private repository? |
Maybe you can reference to README doc, there are some guides to access to different kind of git (also for private repository): |
Allow using private key to access repositories.