Skip to content

Add missing URL to VS Code desktop module #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Nov 28, 2023

Without this the plugin will only work if the user has happened to log in before and that URL was previously saved (and it is the right URL for whatever workspace they are trying to connect). Otherwise, they get an error about localhost (or if the URL is for a different deployment they would get some other issues).

Fixes coder/coder#10896.

Without this the plugin will only work if the user has happened to log
in before and that URL was previously saved.
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@code-asher code-asher merged commit 9fc5eb9 into main Nov 29, 2023
@code-asher code-asher deleted the vscode-desktop-url branch November 29, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to open Workspace from VSCode extension
2 participants