This repository was archived by the owner on May 15, 2025. It is now read-only.
chore: lint for tf/hcl blocks #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Jan 27, 2024
| ) => { | ||
| for (const token of tokens) { | ||
| // Check in-depth. | ||
| if (token.type === "list") { |
There was a problem hiding this comment.
Review: There may be other in-depth cases that are unhandled, but this was present in slackme README, at least.
|
I also added this in #128 |
|
Feel free to import these changes into your PR if you want, there's a difference in that this PR lints all code blocks, even after h1 and within lists. |
matifali
approved these changes
Jan 27, 2024
phorcys420
pushed a commit
to phorcys420-contrib/coder-modules
that referenced
this pull request
Jan 28, 2024
Co-authored-by: Muhammad Atif Ali <atif@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lints that there is at least one
tfblock and nohclblocks in the READMEs.Ref: #134 (comment)