Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

ci: automate version bumps in module README.md files #139

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

matifali
Copy link
Member

closes #138

@matifali matifali requested a review from mafredri January 30, 2024 15:52
@matifali matifali requested a review from mafredri February 12, 2024 16:43
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One improvement suggestion, but otherwise looks good.

One thing to observe here is that a module can go e.g. from v1.0.0 to v1.5.2 in the blink of an eye since we're always bumping them by the coder/modules tag.

We shouldn't fix it in this PR, but eventually it could be nice for them to have their own versions.

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@matifali
Copy link
Member Author

@mafredri, is it possible for each module to have its own versions, given our current setup?

@matifali matifali merged commit b299f98 into main Feb 13, 2024
@matifali matifali deleted the automate-version-bump branch February 13, 2024 12:23
@mafredri
Copy link
Member

@mafredri, is it possible for each module to have its own versions, given our current setup?

Kinda, maybe? Each folder could have its own VERSION file, and it could be incremented based on the change in coder/modules.

Example:

  1. coder/modules v1.5.0 -> v1.5.1
  2. vscode-web/VERSION v1.3.0 -> v1.3.1

Example 2:

  1. coder/modules v1.5.1 -> v1.6.0
  2. vscode-web/VERSION v1.3.1 -> v1.4.0

Perhaps not as ideal as controlling each module individually, but could be an option ¯\_(ツ)_/¯.

@matifali
Copy link
Member Author

@mafredri, but our registry API needs to be changed then, currently, it is based on tags.

@mafredri
Copy link
Member

@mafredri, but our registry API needs to be changed then, currently, it is based on tags.

Don't think it would be a huge effort to do that, if we get some others on board of this being a good idea. Alternatively we can continue using tags but prefix them, like vscode-web-v1.4.0. I bet that would also require some small change to the registry.

@matifali
Copy link
Member Author

Let's see what @bpmct thinks about this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automate version bump in Module docs on new tag pushes
2 participants