Skip to content

Update Hashicorp vault modules #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 13, 2024
Merged

Update Hashicorp vault modules #140

merged 19 commits into from
Feb 13, 2024

Conversation

matifali
Copy link
Member

This pull request adds a new module for authenticating with Hashicorp Vault using a token. The module allows users to configure the Vault address, token, and version of the Vault CLI to install.

@matifali matifali self-assigned this Jan 31, 2024
@matifali matifali requested a review from bpmct February 2, 2024 11:32
@matifali
Copy link
Member Author

matifali commented Feb 7, 2024

The funny thing is this module is copying the code used vault-github which you have previously reviewed.
The only new thing here is using TOKEN and instead of a GitHub token.
I will make changes to both of them.
Thanks @mafredri 😊

@matifali matifali changed the title Add Hashicorp Vault Token module Update Hashicorp vault modules Feb 13, 2024
@matifali matifali requested a review from mafredri February 13, 2024 09:22
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of minor suggestions.

matifali and others added 2 commits February 13, 2024 16:02
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@matifali matifali merged commit ac64af6 into main Feb 13, 2024
@matifali matifali deleted the vault-token-module branch February 13, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants