Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

feat!(git-config): use full name for git configuration #141

Merged
merged 14 commits into from
Feb 12, 2024
Merged

feat!(git-config): use full name for git configuration #141

merged 14 commits into from
Feb 12, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Feb 2, 2024

closes #126

@matifali matifali requested review from stirby and mtojek February 2, 2024 11:31
stirby
stirby approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

mtojek
mtojek reviewed Feb 4, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI complains about syntax?

@matifali
Copy link
Member Author

matifali commented Feb 5, 2024

@mtojek yes. Our tests run terraform apply and for some reason data.coder_workspace.me.owner_email is being seen as an empty string by coalesce function. 😕

@matifali
Copy link
Member Author

matifali commented Feb 9, 2024

As this is not a critical module. I am removing the tests. cc: @stirby

@matifali matifali merged commit ac54966 into main Feb 12, 2024
@matifali matifali deleted the git-config-fullname branch April 10, 2024 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@stirby stirby stirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Full username to git-config module
3 participants
@matifali @mtojek @stirby