fix: fix fetching rc versions of vault cli

[matifali]

Fixes where the install script was fetching the RC version

[mtojek]

Don't you want to use index.json endpoint?

[matifali]

I was avoiding using jq.

[mtojek]

Interesting. Can you shed more light on why? I thought that jq format was more human-friendly.

[matifali]

This is a module, and if a workspace does not have jq, then it will fail. Ideally, we want 0 dependencies if possible, and the module should be useable in any workspace.

@mafredri once suggested having coder util jq|curl|wget|zip|tar type of commands so that we do not depend on anything.

[mtojek]

Gotcha 👍

BTW is grep -P a standard now?

[mafredri]

This is a module, and if a workspace does not have jq, then it will fail. Ideally, we want 0 dependencies if possible, and the module should be useable in any workspace.

@mafredri once suggested having coder util jq|curl|wget|zip|tar type of commands so that we do not depend on anything.

Yup, this is the way, let's reduce dependencies wherever we can 💪🏻. The coder util is a beautiful idea but we also want to make sure we don't bloat the agent binary. Most of this can be done in a very basic way using the stdlib though, so shouldn't add much weight.

Then again, maybe we don't need to bundle it in coder util, perhaps we can have module dependencies and we have one that's called coder/modules/util that contains a few basic commands, or the ability to download them for the relevant platform.

[matifali]

@mafredri @mtojek another option is to use
curl -s https://releases.hashicorp.com/vault/index.json | grep -o '"[0-9]\+\.[0-9]\+\.[0-9]\+"' | tr -d '"' | uniq | sort -V | tail -n 1
without using jq it also uses the index.json endpoint

[mtojek]

another option is to use

I think I like the first option, curl + regular endpoint + grep. As index.json is one-line response, I wouldn't parse it without jq.