Skip to content

feat(jfrog): add option to customize server id for JFrog CLI #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

dimberr
Copy link
Contributor

@dimberr dimberr commented Feb 14, 2024

No description provided.

@matifali
Copy link
Member

matifali commented Feb 16, 2024

Hi @dimberr, could you elaborate on your use case? Why do you need this?
Also, could you update this in a jfrog-token module? We prefer to keep both of them in sync.

@dimberr
Copy link
Contributor Author

dimberr commented Feb 16, 2024

hi @matifali , I updated both jfrog-oauth and jfrog-token.
The use case is simple, we have multiple jfrog-cli configurations, every configuration has different server-id.
In order to send request to specific configured server, jfrog cli has flag --server-id
We want to be able to specify server-id that is configured via this module

@matifali matifali merged commit 8d8910c into coder:main Feb 16, 2024
@dimberr
Copy link
Contributor Author

dimberr commented Feb 17, 2024

@matifali how can I consume that version from master? it still points to old version without the change

@matifali
Copy link
Member

@dimberr It's not available as a tag yet, and I am waiting on #154 to push a new tag. For testing, you can always use the latest version from main by removing version and changing source to

module "jfrog" {
  source = "git::https://github.com/coder/modules.git//jfrog-oauth?ref=main"
  # ...
  # all other options.
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants