Skip to content

Add slug to code server #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

TheZoker
Copy link
Contributor

This PR:

  • Adds a slug var to the code-server module
  • Align the url structure of the vscode-web module with the code-server module

@TheZoker
Copy link
Contributor Author

@mafredri Can you please give me feedback, if the url structure should be the one from the vscode-web module or from the code-server module? Thanks!

@mafredri
Copy link
Member

mafredri commented Feb 15, 2024

@mafredri Can you please give me feedback, if the url structure should be the one from the vscode-web module or from the code-server module? Thanks!

The two modules are separate programs, so there isn't much reason to unify them. Adding the urlencode is probably a good idea, but if the behavior differs between ?folder= and omitting it, then the earlier behavior should be retained. If the behavior is the same between the two forms then the current one is fine (i.e. which folder is opened by default).

@TheZoker TheZoker force-pushed the add-slug-to-code-server branch from 3a07173 to 34beabc Compare February 15, 2024 12:19
@TheZoker
Copy link
Contributor Author

Alright, I reverted the change

@matifali matifali merged commit c00b753 into coder:main Feb 16, 2024
@TheZoker TheZoker deleted the add-slug-to-code-server branch February 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants