Skip to content

Add app_name parameter to code-server #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add app_name parameter to code-server #176

merged 2 commits into from
Mar 6, 2024

Conversation

TheZoker
Copy link
Contributor

No description provided.

@TheZoker
Copy link
Contributor Author

TheZoker commented Mar 1, 2024

An alternative would be to just use the display_name for the app name instead of introducing a new parameter

@matifali matifali requested review from kylecarbs and code-asher March 5, 2024 16:15
code-asher
code-asher reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think using display_name would make sense, we could always add a new variable later if we learn folks need to control it separately.

@TheZoker
Copy link
Contributor Author

TheZoker commented Mar 5, 2024

Thanks for the review!

@TheZoker TheZoker requested a review from code-asher March 5, 2024 22:00
code-asher
code-asher approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me, thank you!

@TheZoker
Copy link
Contributor Author

TheZoker commented Mar 6, 2024

@matifali I think this can be merged then 🙂

@matifali matifali merged commit 7d6c526 into coder:main Mar 6, 2024
@TheZoker TheZoker deleted the add-app-name branch March 6, 2024 12:12
@TheZoker
Copy link
Contributor Author

TheZoker commented Mar 6, 2024

@matifali Thanks! Will there be a "release" soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheZoker @code-asher @matifali