-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add order
variable to coder_app
modules
#177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add per the coder docs coder applications can be reordered in the ui via the order field https://coder.com/docs/v2/latest/templates/resource-ordering#applications
order
variable to coder_app
modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @michaelbrewer. Great contribution. We recently added this functionality so it will only work on deployments on latest release.
We are still looking for a suitable way to check Coder version compatibility with modules that depend on newer features.
See #121
@matifali can we bump the required provider to "0.14.2" when order was added ? terraform {
required_version = ">= 1.0"
required_providers {
coder = {
source = "coder/coder"
version = ">= 0.14.2"
}
}
} |
@michaelbrewer Yes we need to otherwise it won't be updated. |
Set te coder/coder required version to >= 0.14.2 to support the order variable.
@matifali set the required version for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for an approval from @mtojek and then we are good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for working on this! Should we use the latest version of coder provider?
@mtojek - So, i can change the required version to |
I see 👍 I think the last |
Cool @mtojek updated. |
Add per the coder docs coder applications can be reordered in the ui via the order field
https://coder.com/docs/v2/latest/templates/resource-ordering#applications
This change allows this:
Closes coder/modules#178