Skip to content

doc(coder-server): code-server module does not have offline attribute #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Mar 6, 2024

Doc mention offline suport

module "code-server" {
  source         = "registry.coder.com/modules/code-server/coder"
  version        = "1.0.7"
  agent_id       = coder_agent.main.id
  folder         = "/workspace/${local.folder_name}"
  install_prefix = "/workspace/.coder-server"
  offline = true
  settings = {
    "workbench.colorTheme" : "Visual Studio Dark"
    "workbench.startupEditor" : "readme"
  }
  extensions = [
    "ms-python.python",
    "hashicorp.terraform",
    "ms-azuretools.vscode-docker"
  ]
}

However there is no filed for this

Error: Unsupported argument
on main.tf line 219, in module "code-server":
  219:   offline = true
An argument named "offline" is not expected here.

closes #181

@matifali matifali requested a review from kylecarbs March 6, 2024 19:42
@matifali matifali requested a review from code-asher March 11, 2024 08:36
@matifali matifali changed the title doc(coder-server): coder-server module does not have offline attribute doc(coder-server): code-server module does not have offline attribute Mar 11, 2024
@matifali
Copy link
Member

Thoughts on adding the missing attribute instead of removing the example in docs? This can be useful for installations where code-server is baked into the image.

@michaelbrewer
Copy link
Contributor Author

Thoughts on adding the missing attribute instead of removing the example in docs? This can be useful for installations where code-server is baked into the image.

It would be nice to have this feature (which i mention in the github issue), but currently the docs are misleading.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Michael Brewer for helping keep the docs updated.

@matifali matifali merged commit c3d1b41 into coder:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: coder-server does not support offline mode
2 participants