-
Notifications
You must be signed in to change notification settings - Fork 59
feat(vscode-web): add support for settings #195
feat(vscode-web): add support for settings #195
Conversation
Currently saves to `~/.vscode-server/data/Machine/settings.json` as `~/.vscode-server/data/User/settings.json` does not seem to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
||
### Pre-configure Settings | ||
|
||
Configure VS Code's [settings.json](https://code.visualstudio.com/docs/getstarted/settings#_settingsjson) file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a warning that user settings cannot be customized because they are stored in the browser, so only machine settings will work? We could also recommend code-server
if they absolutely need to have user settings, or recommend using settings sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code-asher - maybe for another PR, but i think it would be useful to list out know issues and benefits the differentiate to the options.
ie:
code-server:
- is more functionally complete
- has less issues
- does not support the microsoft marketplace
- does not support some of the microsoft extensions like copilt, liveshare
- does not require wildcard urls
- etc..
vscode-web:
- has issues with port forwarding
- settings issues
- requires wildcard / subdomain = true.
- does not support self-hosted extensions
- supports the microsoft extensions
- etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! This is a good list. code-server has a list of differences from Codespaces (https://github.com/coder/code-server/blob/main/docs/FAQ.md#whats-the-difference-between-code-server-and-github-codespaces) but not the self-hosted version, so we should probably add something there as well (this list is also a little out of date). Some of the differences there apply to the self-hosted version as well though.
Co-authored-by: Asher <ash@coder.com>
Add support for settings, like code-server
Currently saves to
~/.vscode-server/data/Machine/settings.json
as~/.vscode-server/data/User/settings.json
does not seem to work.related to #194
closes #196