feat: add coder_parameter_order to all data.coder_parameter fields

[michaelbrewer]

Add coder_parameter_order variable to modules that have a data coder_parameter

• aws-region
• azure-region
• dotfiles
• exoscale-instance-type
• exoscale-zone
• gcp-region
• git-config (has 2 parameters)

Examples

NOTE: add coder_parameter_order for git-config could be increments by one, gcp-region order should be higher to start with. So intervals by 10 is always safe

module "git-config" {
  source                = "registry.coder.com/modules/git-config/coder"
  version               = "1.0.11"
  agent_id              = coder_agent.example.id
  allow_email_change    = true
  coder_parameter_order = 10
}

module "gcp-region" {
  source                = "registry.coder.com/modules/gcp-region/coder"
  version               = "1.0.11"
  regions               = ["us", "europe"]
  coder_parameter_order = 20
}

// etc..

related to #207

[mafredri]

Would it be feasible to just use one coder_parameter_order for all parameters? If someone wants to change these individually, then there may be something wrong with the module or how it's being used.

Why? This makes modules updates more risky. If we ever add a third parameter, it could end up anywhere when the user updates.

Perhaps we can still apply order if it's given, e.g. order = var.coder_parameter_order ? var.coder_parameter_order + 0 : null, + 1, etc.

An author can reserve as much ordered space for a module as they wish.

module "git-config" {
  source                = "registry.coder.com/modules/git-config/coder"
  version               = "1.0.11"
  agent_id              = coder_agent.example.id
  allow_email_change    = true
  coder_parameter_order = 10
}

module "gcp_region" {
  source                = "registry.coder.com/modules/gcp-region/coder"
  version               = "1.0.11"
  regions               = ["us", "europe"]
  coder_parameter_order = 20
}

To clarify this, maybe we could name it something like coder_parameter_group_order or coder_parameter_order_weight, I'm open to better ideas 😄.

[michaelbrewer]

True, i can keep it all the same field name.

[michaelbrewer]

@mafredri - i have updated the code and tests

[mafredri]

Nice work, thanks for the PR!