feat(jetbrains-gateway): Allow fetching latest version dynamically #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
commented
Apr 15, 2024
matifali
commented
Apr 15, 2024
matifali
commented
Apr 15, 2024
mafredri
approved these changes
Apr 15, 2024
|
Nice work! Do you think we'll need to proxy the latest lookups so that we can cache it and avoid hitting JetBrains API all the time? |
|
Yes. However, I am unclear on how we can achieve caching the latest. Any suggestions? |
matifali
commented
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to fetch the JetBrains IDE's latest version dynamically. It adds a new variable to fetch the latest version. The
data.http.jetbrains_ide_versionsdata source retrieves the latest version information.TODO: Add tests (probably in a separate PR)
Closes #217