feat(vscode-web): add offline, use_cached, extensions_dir and auto_install_extensions

[michaelbrewer]

• Pending the reveiw and acceptance of feat(code-server): install extensions from .vscode/extensions.json #231

[code-asher]

Looks good to me, but I think we should use the same name in all the comments/output/functions (maybe VS Code Web).

[matifali]

I think I have suggested all the name changes, but I could have missed some.

[michaelbrewer]

I think I have suggested all the name changes, but I could have missed some.

some of this was there from before and some of it was exactly working code from the code-server implementation. I have accepted all your suggestions, but i will need to retest and fix CI errors.

[matifali]

Thank you, @michaelbrewer ❤️ . You are doing a great job of making modules super helpful.

Let's wait for an approval from @code-asher and I will merge and cut a release.

[michaelbrewer]

Thank you, @michaelbrewer ❤️ . You are doing a great job of making modules super helpful.

Let's wait for an approval from @code-asher and I will merge and cut a release.

Would be nice to have official templates is composed of modules. :)

[matifali]

Would be nice to have official templates is composed of modules. :)

I have also thought about this and created an issue. But Coder bundles starter templates within the product and when we add modules that are fetched from registry, this does not work on restricted or air-gapped deployments.

[michaelbrewer]

Would be nice to have official templates is composed of modules. :)

I have also thought about this and created an issue. But Coder bundles starter templates within the product and when we add modules that are fetched from registry, this does not work on restricted or air-gapped deployments.

Most of the included examples don't run air-gapped as they would curl to install code-server.

Maybe https://developer.hashicorp.com/terraform/language/providers/requirements#source-addresses to allow for registry.coder.com ?

[michaelbrewer]

Scanning through the examples you can see cases of this:

• examples/templates/aws-devcontainer/main.tf - (https://get.docker.com and https://registry.coder.com/modules/code-server etc..)
• examples/templates/aws-linux/main.tf - (https://code-server.dev/install.sh)
• examples/templates/docker/main.tf - (https://code-server.dev/install.sh)
  etc..

[code-asher]

Thank you @matifali for all finding all the spots to update the name! Absolutely perfect.

I made a few more minor suggestions that I missed the first time around, nothing worth blocking over though so feel free to merge.

Thank you @michaelbrewer for putting this together!

[code-asher]

Just occurred to me, should this be considered a failure?

Suggested change

	exit 0
	exit 1

[michaelbrewer]

I am not sure. From a user perspective it would be nice to continue without an error and print a warning

[michaelbrewer]

I guess there is where monitoring works when errors happen in a large deployment.

[code-asher]

Oh if exit 1 prevents the workspace from starting then yeah, better to continue.

[matifali]

it doesn't prevent the workspace from starting but does show a warning on the page that the script was not successful.

[code-asher]

Ahh gotcha yeah exit 1 seems like the right move then.

[matifali]

I think it's fine. If we don't fine jw we should just skip installing extensions and continue with the rest of the script.

[code-asher]

I have mixed feelings about it, because enabling autoinstall without jq is a bug the template author has to fix (I think, right?), and not showing the error could make it so no one notices.

On the other hand, it does seem annoying as a user that I cannot launch VS Code just because someone forgot to install jq.

stderr gets highlighted in the terminal, right? Maybe we output to stderr and then keep going.

Also if we use node instead, we avoid the problem entirely.

[michaelbrewer]

I will try the node to in another PR.