Skip to content

feat: Add github-upload-public-key module #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 2, 2024
Merged

feat: Add github-upload-public-key module #241

merged 23 commits into from
May 2, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Apr 26, 2024

Automates uploading Coder public key to Github so users don't have to.

First build:
Screenshot 2024-05-02 at 2 35 35 PM

Subsequent builds:
Screenshot 2024-05-02 at 2 36 02 PM

Github Auth not linked:
Screenshot 2024-05-02 at 2 36 54 PM

Closes https://github.com/coder/customers/issues/542

@f0ssel f0ssel marked this pull request as ready for review April 30, 2024 17:16
@f0ssel f0ssel requested review from kylecarbs and matifali April 30, 2024 17:16
@f0ssel
Copy link
Contributor Author

f0ssel commented Apr 30, 2024

Working on adding some tests

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we generalize GitHub URL too by making it an input to the module or better deducing it from the configured GitHub external authentication.

@f0ssel f0ssel requested a review from matifali May 1, 2024 19:53
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely sick!

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language things that I think could be helpful!

@f0ssel
Copy link
Contributor Author

f0ssel commented May 2, 2024

I realize there is a conflict between making tests pass and the script actually working in workspaces, I think I need to handle the terraform injection (I didn't know this was actually happening at first) as well as env vars for tests.

@f0ssel
Copy link
Contributor Author

f0ssel commented May 2, 2024

Okay input variable issues are fixed, screenshots are updated, I think this is g2g but I'll wait until the eod to merge so yall can take a look at the last couple changes since review.

@f0ssel f0ssel merged commit cd0c730 into main May 2, 2024
2 checks passed
@f0ssel f0ssel deleted the f0ssel/github-key branch May 2, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants