-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Add github-upload-public-key module #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Working on adding some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we generalize GitHub URL too by making it an input to the module or better deducing it from the configured GitHub external authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely sick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language things that I think could be helpful!
I realize there is a conflict between making tests pass and the script actually working in workspaces, I think I need to handle the terraform injection (I didn't know this was actually happening at first) as well as env vars for tests. |
Okay input variable issues are fixed, screenshots are updated, I think this is g2g but I'll wait until the eod to merge so yall can take a look at the last couple changes since review. |
Automates uploading Coder public key to Github so users don't have to.
First build:

Subsequent builds:

Github Auth not linked:

Closes https://github.com/coder/customers/issues/542