This repository was archived by the owner on May 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
fix(code-server): USE_CACHED should still install extensions #252
Merged
+20
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When USE_CACHED is true and no extensions have been installed Then we should still try to install them
@mafredri something weird is happening with |
@code-asher - here is the PR for fixing cases where code-server has been reinstalled, but not any of the extensions. |
code-asher
reviewed
May 29, 2024
@code-asher a little simpler to only support installing extension when the the EXTENSION_DIR is set |
@code-asher you are right :). Installing again when there are ones that already exist is really fast |
code-asher
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
code-asher
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When USE_CACHED is true and no extensions have been installed Then we should still try to install them
close #251
Tests performed
bun test -t code-server
Scenario: use_cached and extensions_dir is set, but no extensions installed
Given
USE_CACHED
istrue
AND a cached copy of code-server
AND we have a list of extensions to install at startup
Then we expect the extensions to be installed
Output when no extensions was installed before
Output if extensions was already installed before
Scenario: offline = true
Expected output