Skip to content

fix url schema for webrdp example #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix url schema for webrdp example #270

merged 1 commit into from
Jul 17, 2024

Conversation

stirby
Copy link
Contributor

@stirby stirby commented Jul 16, 2024

Tested the corrected URL on dogfood.

Was

module "windows_rdp" {
  source      = "registry.coder.com/coder/module/windows-rdp"
  ...
}

Now

module "windows_rdp" {
  source      = "registry.coder.com/modules/windows-rdp/coder"
  ...
}

@stirby stirby requested review from Parkreiner and matifali July 16, 2024 19:31
@stirby

This comment was marked as resolved.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an overlook from last review.
Thank you for noting this.

@stirby stirby merged commit f7f9c8b into main Jul 17, 2024
2 checks passed
@matifali matifali deleted the webrdp-link branch October 17, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants