-
Notifications
You must be signed in to change notification settings - Fork 57
fix(filebrowser): failed to set server_base_path if db is not existing #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On the first start, the DB do not exist and the "filebrowser config set --baseurl" will failed. filebrowser was starting with the wrong baseurl (subdomain=false). it starts correctly on the second try if the db was persisted. this fix set the correct baseurl even if the db was not existing
Thanks, @dstoffel, for the contribution. I have a few suggestions. Please also run |
@dstoffel, can you address the suggestion and make sure CI passes? Thanks again for your contribution. |
Co-authored-by: M Atif Ali <me@matifali.dev>
i cannot have bun working on my machine. I'm still having the issue : error: Executable not found in $PATH: "terraform" related issue: #389 I'm using exactly the same version that the CI is using:
If i try with the same ci.yaml (github action) on my fork repo, i also have the same error: https://github.com/dstoffel/coder-modules/actions/runs/13154797963/job/36709410893 I don't understand how the test is going to the next step when it run inside your actions. Thanks, EDIT: just found #390 , i will try with this fix |
On the first start, the DB does not exist and the "filebrowser config set --baseurl" will failed. filebrowser was starting with the wrong baseurl (subdomain=false). it starts correctly on the second try if the db was persisted. this fix set the correct baseurl even if the db was not existing