Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

feat(code-server): add machine settings option #449

Closed
wants to merge 6 commits into from

Conversation

djarbz
Copy link
Contributor

@djarbz djarbz commented Apr 25, 2025

This PR resolves coder/registry#27.

The goal is to provide a method for template owners to configure default Machine Settings that can be overridden by developers via User Settings and repositories via Workspace Settings.
This option allows template owners to push new settings options with a template release that would not be ignored because the setting file already exists.

Eventually, I would imagine the current settings option will be depreciated in favor of this option.
Alternatively, we could hijack that option to operate on the machine level settings before merging this PR.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Apr 25, 2025
@djarbz djarbz changed the title feat(code-server): Machine Settings option feat(code-server): add machine settings option Apr 25, 2025
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove existing functionality
And bump minor version.

@djarbz
Copy link
Contributor Author

djarbz commented May 8, 2025

Looks like my fetch sync didn't work properly the first go-around.
Should be good now.

@matifali
Copy link
Member

matifali commented May 9, 2025

We are moving to https://github.com/coder/regitsry. Please move your PR there. Thanks
More context in #469

@matifali matifali closed this May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC(Coder-Server): Template Settings
2 participants