chore: remove invalid field #51
Conversation
It is an alloy field, not a grafana agent one
| version: 1.14.1 | ||
| version: 1.14.2 |
| @@ -118,8 +118,6 @@ global: | |||
| scrape_interval: 60s | |||
| # global.telemetry.profiling.scrape_timeout -- how long a request will be allowed to wait before being canceled | |||
| scrape_timeout: 70s | |||
| # global.telemetry.profiling.delta_profiling_duration -- duration of each pprof profiling capture, must be less than scrape_interval | |||
| delta_profiling_duration: 30s | |||
There was a problem hiding this comment.
Shouldn't we be setting delta=true?
There was a problem hiding this comment.
I don't think so. That argument is for profile.custom blocks.
https://grafana.com/docs/agent/latest/flow/reference/components/pyroscope.scrape/#delta-argument
Here are the arguments for pyroscope.scrape: https://grafana.com/docs/agent/latest/flow/reference/components/pyroscope.scrape/#arguments
There was a problem hiding this comment.
At least, I am not sure how to set up delta and where to put the custom profile block 🤔.
I assume we are using some standard profiling configuration with the /debug/pprof/profile endpoint. I'd rather not manually configure it if we can avoid it.
There was a problem hiding this comment.
OK cool, let's see how this fares.
It is an alloy field, not a grafana agent one