feat: allow deploying dashboard and alerts on existing instances #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
force-pushed
the
feat/dashboard-labels
branch
3 times, most recently
from
8acd058 to
4cd9c53
Compare
aslafy-z
force-pushed
the
feat/dashboard-labels
branch
3 times, most recently
from
47bb49f to
dd9620a
Compare
|
@aslafy-z thanks very much for your contribution. I'll be on PTO until Mon 13th, and my colleague who is co-maintaining this with me is away as well. Would it be ok with you if I got to this when I return? |
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
aslafy-z
force-pushed
the
feat/dashboard-labels
branch
from
dd9620a to
651a327
Compare
|
@dannykopping sure, enjoy your pto! |
There was a problem hiding this comment.
Overall LGTM! Thanks for a great contribution @aslafy-z
Left a few notes
coder-observability/templates/dashboards/_dashboards_prebuilds.json.tpl
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,34 @@ | |||
| {{- if and .Values.global.alerts.enabled (eq .Values.global.alerts.format "prometheusrule") -}} | |||
There was a problem hiding this comment.
Have you tested this out with Prometheus disabled and observed everything working as expected?
There was a problem hiding this comment.
I added a mention to the description. I had no time to test these changes for the moment.
There was a problem hiding this comment.
They don't necessarily have to have been tested in production, but the code must have at least been validated manually using Prom Operator for us to accept the change.
| configMap: metrics-alerts | ||
| configMap: coder-metrics-alerts | ||
| readonly: true | ||
| optional: true |
There was a problem hiding this comment.
Should the other configmaps also be optional?
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/_dashboards_coderd.json.tpl
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/_dashboards_provisionerd.json.tpl
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/_dashboards_workspace_detail.json.tpl
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/_dashboards_workspaces.json.tpl
Outdated
Show resolved
Hide resolved
Tracked with coder#63
Co-authored-by: Danny Kopping <dannykopping@gmail.com>
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/configmap-dashboards-prebuilds.yaml
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/configmap-dashboards-provisionerd.yaml
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/configmap-dashboards-status.yaml
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/configmap-dashboards-workspace_detail.yaml
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/configmap-dashboards-workspaces.yaml
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
coder-observability/templates/dashboards/configmap-dashboards-coderd.yaml
Outdated
Show resolved
Hide resolved
aslafy-z
commented
Oct 13, 2025
…ds.labels' Co-authored-by: Danny Kopping <dannykopping@gmail.com>
aslafy-z
commented
Oct 13, 2025
aslafy-z
commented
Oct 13, 2025
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes to allow the use of this Helm chart with existing infrastructure components such as Prometheus Operator and Grafana.
global.alerts.enabled(new value): enable/disable deployment of alertsglobal.alerts.kind(new value): alerts container resource (configmaporprometheusrule) (Prometheus Operator compatibility)global.dashboards.enabled(new value): enable/disable deployment of dashboardsglobal.dashboards.labels(new value): allow to set dashboard configmaps a label (Grafana Sidecar compatibility)runbookViewer.enabled(new value): enable/disable deployment of the runbook viewergrafana-agentis enabledCoderand Grafana uid(posponed Make Grafana dashboards' UIDs consistent #63) bycoder-It does not fix #31 but helps people that only want to deploy dashboards and alerts for example.
This PR was NOT tested in real world conditions.