-
Notifications
You must be signed in to change notification settings - Fork 40
feat: tmux module #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tmux module #229
Conversation
@matifali please review. |
@DevelopmentCats let me know if this needs any changes :) |
My bad, added frontmatter. |
Hey - We should have clarified this in the issue, but the ability to pre-define sessions in the module via variables, then them to show up as |
Doable 👍🏻 (
Ok, so it will show up in the UI as a button and then we redirect them to existing terminal and start the tmux server with that session ? Can you explain the expected flow. |
Yes. We used to do this in the claude code module. here is an example: registry/registry/coder/modules/claude-code/main.tf Lines 232 to 267 in 8e051a8
|
@bpmct let me know if it needs any more changes :) |
Can you take a look at the changes that I requested above? I know you addressed some of them like the variables in the readme and stuff but I think I had added some more in the same review below |
@DevelopmentCats resolved all the reviews. |
@matifali @DevelopmentCats fixed the CI. |
I was testing this and I actually noticed one minor issue with the README @35C4n0r Can you add the version field to all 3 examples like it is in the first one? Other than this minor issue, Great Work! |
@DevelopmentCats added! |
Closes #203
/claim #203
Description
Introduce the
tmux
moduleDemo
https://www.loom.com/share/ec8169d34c3043f7af2163b1a1a14a4b?sid=1ea8bcb2-3db0-43ca-965a-5ed42eec3448
Type of Change
Module Information
Path:
registry/anomaly/modules/tmux
New version:
v1.0.0
Breaking change: [ ] Yes [x] No
Testing & Validation
bun test
)bun run fmt
)Related Issues
#203