Skip to content

feat(code-server): add machine settings option #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

djarbz
Copy link
Contributor

@djarbz djarbz commented May 9, 2025

Should resolve #27

The goal is to provide a method for template owners to configure default Machine Settings that can be overridden by developers via User Settings and repositories via Workspace Settings.
This option allows template owners to push new settings options with a template release that would not be ignored because the setting file already exists.
This also formats the settings.json file if jq is installed.

Eventually, I would imagine the current settings option will be depreciated in favor of this option.

@DevelopmentCats
Copy link
Contributor

I'm going to test this out in a template, and then I will update.

@matifali matifali added the version:minor Add to PRs requiring a minor version upgrade label May 15, 2025
@DevelopmentCats
Copy link
Contributor

I was taking another look at everything before testing, I noticed something about the settings.json formatting. You are using jq when it's installed, which is great, but maybe we should check if jq is available first and install it automatically if it's missing? That way we can ensure consistent formatting for all users rather than having it depend on whether they happen to have jq installed already.

@djarbz
Copy link
Contributor Author

djarbz commented May 15, 2025

I'm hesitant to add a dependency just for that.
Updating the package list and installing takes time, I would rather a quick stand-up than to have to wait for jq to install.
Formatting is moreso a nice-to-have, I don't expect many to manually modify the file and rather edit from the settings menu.

@DevelopmentCats
Copy link
Contributor

Okay that works.

I'll test this when I get home in a bit and then I'll merge.

Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and its working fine.

@DevelopmentCats DevelopmentCats merged commit 84f3cb5 into coder:main May 16, 2025
3 checks passed
DevelopmentCats added a commit that referenced this pull request May 16, 2025
@DevelopmentCats
Copy link
Contributor

Need to add Versions in README for code-server

@DevelopmentCats
Copy link
Contributor

@djarbz Can you make a new PR so we can update the versions and then merge?

@djarbz
Copy link
Contributor Author

djarbz commented May 16, 2025

@DevelopmentCats Do I need to update the versions? From what I had read in the contributors.md, that was handled internally. Unless I am mistaken?

@DevelopmentCats
Copy link
Contributor

DevelopmentCats commented May 16, 2025

@djarbz

We will need to manually update them for now.

In the near future this will be handled automatically, but as of now we will need to update the readme before release

edit:

I'll also take a look at updating the contributions doc to make it a little more clear.

DevelopmentCats pushed a commit that referenced this pull request May 16, 2025
Reimplements the changes in #88
with the manual version bump to 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:minor Add to PRs requiring a minor version upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC(Coder-Server): Template Settings
3 participants