-
Notifications
You must be signed in to change notification settings - Fork 8
feat(code-server): add machine settings option #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code-server): add machine settings option #88
Conversation
I'm going to test this out in a template, and then I will update. |
I was taking another look at everything before testing, I noticed something about the settings.json formatting. You are using jq when it's installed, which is great, but maybe we should check if jq is available first and install it automatically if it's missing? That way we can ensure consistent formatting for all users rather than having it depend on whether they happen to have jq installed already. |
I'm hesitant to add a dependency just for that. |
Okay that works. I'll test this when I get home in a bit and then I'll merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and its working fine.
This reverts commit 84f3cb5.
Need to add Versions in README for code-server |
@djarbz Can you make a new PR so we can update the versions and then merge? |
@DevelopmentCats Do I need to update the versions? From what I had read in the contributors.md, that was handled internally. Unless I am mistaken? |
We will need to manually update them for now. In the near future this will be handled automatically, but as of now we will need to update the readme before release edit: I'll also take a look at updating the contributions doc to make it a little more clear. |
Reimplements the changes in #88 with the manual version bump to 1.1.0
Should resolve #27
The goal is to provide a method for template owners to configure default
Machine Settings
that can be overridden by developers viaUser Settings
and repositories viaWorkspace Settings
.This option allows template owners to push new settings options with a template release that would not be ignored because the setting file already exists.
This also formats the
settings.json
file ifjq
is installed.Eventually, I would imagine the current
settings
option will be depreciated in favor of this option.