This repository has been archived by the owner on Jan 17, 2021. It is now read-only.
Pass ssh flags to rsync #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
force-pushed
the
ssh-flags-rsync
branch
from
afc57e9
to
fedfbb7
Compare
scsmithr
reviewed
Apr 20, 2019
main.go
Outdated
| if err != nil { | ||
| flog.Fatal("failed to sync settings: %v", err) | ||
| } | ||
| flog.Info("synced settings in %s", time.Since(start)) | ||
|
|
||
| flog.Info("syncing extensions") | ||
| err = syncExtensions(host) | ||
| err = syncExtensions(host, *sshFlags) |
nhooyr
approved these changes
Apr 20, 2019
main.go
Outdated
| `/bin/bash -c 'set -euxo pipefail || exit 1 | ||
| wget -q https://codesrv-ci.cdr.sh/latest-linux -O `+codeServerPath+` | ||
| downloadScript := `/bin/bash -c 'set -euxo pipefail || exit 1 | ||
| wget -q https://codesrv-ci.cdr.sh/latest-linux -O ` + codeServerPath + ` |
There was a problem hiding this comment.
No idea how that got there.. That script is completely broken. We're going to want some tests
There was a problem hiding this comment.
I think its a good idea we http.Get on our side and then just write the binary to the remote side if it has changed. Would be nice and easy to test as well versus bash scripts.
There was a problem hiding this comment.
The problem is the bin is 90MB.
- Also use ssh flags when running the download script Resolves #19
ammario
force-pushed
the
ssh-flags-rsync
branch
from
6aa641b
to
53fc8fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19