Add a --bind flag for local port #82

teddy-codes · 2019-04-30T23:54:45Z

Resolves #78

sreya

I think instead of exposing the flag to the user, we should detect the remote environment from within sshcode and if the remote environment is ChromeOS we modify the host value.

sshcode.go

teddy-codes · 2019-05-01T20:03:29Z

I am not entirely sure that there is a way to detect if the OS is ChromeOS. I have looked at go tool dist list and the only thing that I have found is linux/*, so I am not sure about the way to do this. I thought that exposing the option to the end user was the best because it always allows for local network access (killing 2 birds with one stone). As a side note, using 0.0.0.0 does not expose your computer to the world unless you have the random port by chance open on your network and the port forwarded to your machine. 0.0.0.0 only opens your computer up to your local network.

sreya · 2019-05-01T20:19:47Z

If you had a malicious user on your local network then it could be dangerous, though I would agree in practice that's unlikely to happen. To reiterate I'd rather not expose that option to the user, the goal of sshcode is to provide a secure, simple way to connect to your code-server instance so I'd like to avoid anything that would enable the user to do otherwise

sreya · 2019-05-01T20:20:33Z

I'll do some research to see if we can detect if an environment is ChromeOS

teddy-codes · 2019-05-01T20:22:13Z

what would you propose as the resolution?

sreya · 2019-05-01T20:23:23Z

To update the host value conditionally based on whether the remote instance is ChromeOS

teddy-codes · 2019-05-04T21:09:11Z

@sreya92 It looks like lsb_release -a returns Gentoo, but not sure how we would implement that in the flow...

- Added check for gentoo on remote instance.

deansheather · 2019-05-06T15:42:13Z

Gentoo is an actual Linux distribution which I assume ChromeOS builds off of. This solution will also work on actual Gentoo distributions as well.

teddy-codes · 2019-05-06T16:30:45Z

How is it possible to differentiate the two?

sreya · 2019-05-07T18:26:41Z

@roberthmiller I looked into this a good bit too and couldn't find a good indicator...after talking with @ammario I think the best solution is to go with a flag that we expose to the user like you originally proposed, I think we call it --bind, is this something you'd still like to work on?

- Added check for gentoo on remote instance.

teddy-codes · 2019-05-07T21:45:40Z

I did not remove localPort from the options struct because the test was using it.

sreya

Also need to update the test to reflect the updated changes to the options

sshcode.go

main.go

Zate · 2019-05-07T22:33:50Z

I'm not sure the bind to localhost is the right option for ChromeOS. Running this on ChromeOS is likely to only be done through Crostini. Crostini is a Debian Stretch based container that sits inside the ChromeOS managed by a VM (Termina). It can be reached by the name "penguin.linux.test" in it's default state and anything listening in the container on 0.0.0.0 will generally be able to be hit. I don't really think there will be a huge need to ssh into the Crostini container as it's not exposed externally by default.

You can use sshcode from inside that container to an external ssh host and it opens up in the ChromeOS browser just fine using www-browser --url https://<urltocode:port. The --app doesnt work though because the garcon grpc connector through to the main ChromeOS doesn't support it (yet).

The real I would simply add either a --chromeos flag, or a --local flag, or actually have it detect the crostini container by looking for /opt/google/cros-containers folder, or /ChromeOS/ folder or a few others. The /opt/google/cros-containers contains some binaries (such as garcon) with are only present in correctly setup and mounted penguin containers under ChromeOS (so far that I have seen).

If you accurately work out its Crostini, or allow the users to specify via a flag, you basically just "skip" the shh part and pretend this is the server you ssh'd to and set everything up. Download the binary, setup the folders etc (no where really to sync the extensions etc from unless perhaps from a local vscode install). You then call the www-browser binary and pass it the http://penguin.linux.test:port url and it will pop up inside the regular ChromeOS environment and work as if it was remote.

Why would someone want this? Well, the experience of running code inside a browser is actually smoother than running it natively in the crostini container in my testing. Plus having it just in a tab vs a stand alone window is simple and easy.

I've got some code somewhere I could dig up that got this working on my pixelbook, plus some that started on porting sshcode to work under powershell/windows. (Kinda paused that to see how the new terminal on windows plays out).

sreya · 2019-05-07T23:11:26Z

@Zate this is to fix using ChromeOS as a client not a server. Currently you cannot tunnel to localhost on a chromeOS client and access code-server from the browser

sreya · 2019-05-07T23:20:59Z

sshcode.go

-		o.localPort, err = randomPort()
+	var bindHost string
+	var bindPort string
+	bindHost, bindPort, err = net.SplitHostPort(o.bindAddr)


you can short assign this :=

I can't because of the reassignment of err

sreya · 2019-05-07T23:32:08Z

sshcode.go

+	if err != nil {
+		return xerrors.Errorf("failed to parse bind address: %w", err)
+	}
+	if bindPort == "" {


I would probably pull this out into a separate function func parseBindAddr(bindAddr string) (bindAddr string, err error) that splits the address and ensures that neither host nor port is empty. If one is, it gets assigned a default value, 127.0.0.1 for host, and a random port for port and then join it back together with net.JoinHostPort

sreya · 2019-05-07T23:35:49Z

sshcode.go

@@ -93,11 +101,12 @@ func sshCode(host, dir string, o options) error {
 		return xerrors.Errorf("failed to find available remote port: %w", err)
 	}

-	flog.Info("Tunneling local port %v to remote port %v", o.localPort, o.remotePort)
+	flog.Info("Tunneling local host %v:%v to remote port %v", bindHost, bindPort, o.remotePort)


I'd probably reword to say Tunneling remote port %v to %v, o.remotePort, bindAddr

sreya · 2019-05-07T23:37:43Z

sshcode_test.go

@@ -37,7 +37,7 @@ func TestSSHCode(t *testing.T) {
 		defer wg.Done()
 		err := sshCode("foo@127.0.0.1", "", options{
 			sshFlags:   testSSHArgs(sshPort),
-			localPort:  localPort,
+			bindAddr:   fmt.Sprintf("127.0.0.1:%v", localPort),


net.JoinHostPort("127.0.0.1", localPort)

sreya · 2019-05-07T23:38:14Z

main.go

@@ -52,6 +54,8 @@ func (c *rootCmd) RegisterFlags(fl *flag.FlagSet) {
 	fl.BoolVar(&c.skipSync, "skipsync", false, "skip syncing local settings and extensions to remote host")
 	fl.BoolVar(&c.syncBack, "b", false, "sync extensions back on termination")
 	fl.BoolVar(&c.printVersion, "version", false, "print version information and exit")
+	fl.BoolVar(&c.noOpen, "no-open", false, "do not open web browser")


after speaking with a colleague let's handle the no-open in a separate PR, sorry for indicating otherwise earlier

No worries. WIll change it

Zate · 2019-05-08T01:13:12Z

@Zate this is to fix using ChromeOS as a client not a server. Currently you cannot tunnel to localhost on a chromeOS client and access code-server from the browser

I assume by ChromeOS you mean the crostini container inside ChromeOS, or are you talking about a device in "dev mode" where you have shell access to ChromeOS itself, or even via crouton? Sorry I assumed this was related to something I posted a while ago #28 because I got a reference to this pull request.

teddy-codes · 2019-05-08T01:17:23Z

Yes, my bad. I thought that you meant via as a client, but did not fully understand your issue. Also, I believe that this fixes crostini, but am not completely sure as I do not have a chromebook.

sreya · 2019-05-08T01:20:38Z

No worries apologies for any confusion, to clarify this fixes the specific case of running sshcode to crostini.

…

On Tue, May 7, 2019 at 8:13 PM Zate ***@***.***> wrote: @Zate <https://github.com/Zate> this is to fix using ChromeOS as a client not a server. Currently you cannot tunnel to localhost on a chromeOS client and access code-server from the browser I assume by ChromeOS you mean the crostini container inside ChromeOS, or are you talking about a device in "dev mode" where you have shell access to ChromeOS itself, or even via crouton? Sorry I assumed this was related to something I posted a while ago #28 <#28> because I got a reference to this pull request. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFBTBDRHURWOH6S5FKRSZLPUISKTANCNFSM4HJQ7YAQ> .

Zate · 2019-05-08T02:33:05Z

I'll do some testing with it but I don't think this is the right way to deal with crostini. Will let you know after I test it though.

added fix for chromeos host

4642896

teddy-codes mentioned this pull request May 1, 2019

bind to address on eth0 in ChromeOS #54

Closed

sreya suggested changes May 1, 2019

View reviewed changes

sshcode.go Outdated Show resolved Hide resolved

teddy-codes added 2 commits May 4, 2019 17:26

Removed host options

72c42b1

- Added check for gentoo on remote instance.

Removed host

f622dad

This was referenced May 7, 2019

chromeos connection refused #93

Closed

specify port and don't bring up browser? #95

Closed

teddy-codes added 7 commits May 7, 2019 15:14

added remoteHost option

9d262bc

expose localPort

8df5e51

added fix for chromeos host

fe26cff

Removed host options

8e4a734

- Added check for gentoo on remote instance.

Removed host

7c9e276

added remoteHost option

7c4434d

Merge branch 'master' of github:roberthmiller/sshcode

6ad37b6

teddy-codes changed the base branch from master to fix-display May 7, 2019 19:46

teddy-codes changed the base branch from fix-display to master May 7, 2019 19:46

teddy-codes added 3 commits May 7, 2019 16:14

changes

fbede72

description change

bec6ac7

expose noOpen to the user

56cb648

teddy-codes mentioned this pull request May 7, 2019

Support a --local flag? #28

Open

remove local-port from being exposed

f9bb374

sreya suggested changes May 7, 2019

View reviewed changes

sshcode.go Outdated Show resolved Hide resolved

sshcode.go Outdated Show resolved Hide resolved

sshcode.go Outdated Show resolved Hide resolved

sshcode.go Outdated Show resolved Hide resolved

sshcode.go Outdated Show resolved Hide resolved

main.go Outdated Show resolved Hide resolved

teddy-codes changed the title ~~added fix for chromeos host~~ added fix for chromeos client May 7, 2019

updated code based on review.

757daeb

sreya suggested changes May 7, 2019

View reviewed changes

teddy-codes added 3 commits May 7, 2019 19:57

Changed based on review

367f177

Do not expose no-open

37086a0

Removed noOpen from options

3741703

sreya approved these changes May 8, 2019

View reviewed changes

sreya changed the title ~~added fix for chromeos client~~ Add a --bind flag for local port May 8, 2019

sreya merged commit dbc0ff5 into coder:master May 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a --bind flag for local port #82

Add a --bind flag for local port #82

teddy-codes commented Apr 30, 2019

sreya left a comment

teddy-codes commented May 1, 2019

sreya commented May 1, 2019 •

edited

Loading

sreya commented May 1, 2019

teddy-codes commented May 1, 2019

sreya commented May 1, 2019

teddy-codes commented May 4, 2019

deansheather commented May 6, 2019

teddy-codes commented May 6, 2019

sreya commented May 7, 2019

teddy-codes commented May 7, 2019

sreya left a comment

Zate commented May 7, 2019

sreya commented May 7, 2019 •

edited

Loading

sreya May 7, 2019

teddy-codes May 7, 2019

sreya May 7, 2019

sreya May 7, 2019

sreya May 7, 2019

sreya May 7, 2019

sreya May 7, 2019

teddy-codes May 7, 2019

Zate commented May 8, 2019

teddy-codes commented May 8, 2019

sreya commented May 8, 2019 via email

Zate commented May 8, 2019

Add a --bind flag for local port #82

Add a --bind flag for local port #82

Conversation

teddy-codes commented Apr 30, 2019

sreya left a comment

Choose a reason for hiding this comment

teddy-codes commented May 1, 2019

sreya commented May 1, 2019 • edited Loading

sreya commented May 1, 2019

teddy-codes commented May 1, 2019

sreya commented May 1, 2019

teddy-codes commented May 4, 2019

deansheather commented May 6, 2019

teddy-codes commented May 6, 2019

sreya commented May 7, 2019

teddy-codes commented May 7, 2019

sreya left a comment

Choose a reason for hiding this comment

Zate commented May 7, 2019

sreya commented May 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zate commented May 8, 2019

teddy-codes commented May 8, 2019

sreya commented May 8, 2019 via email

Zate commented May 8, 2019

sreya commented May 1, 2019 •

edited

Loading

sreya commented May 7, 2019 •

edited

Loading