Skip to content
This repository has been archived by the owner on Jan 17, 2021. It is now read-only.

Some updates for document #89

Merged
merged 4 commits into from
May 6, 2019
Merged

Some updates for document #89

merged 4 commits into from
May 6, 2019

Conversation

tokikanno
Copy link
Contributor

  1. remote directory parameter MUST be quoted on some OS (like MacOS)
  2. OS has no X-window installed (like MacOS) need to set a fake DISPLAY env variable for enabling the auto open in browser feature.

For OS has no X-Window installed(e.g.: MacOS), you need to set a fake
DISPLAY env for the auto open in browser function working.
@tokikanno tokikanno changed the title Some update for document Some updates for document May 3, 2019
Copy link
Collaborator

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for these doc updates! I had some very minor comments on the verbiage but once they are addressed I'll merge this in. Thanks again!

@@ -46,7 +46,7 @@ sshcode kyle@dev.kwc.io
You can specify a remote directory as the second argument:

```bash
sshcode kyle@dev.kwc.io ~/projects/sourcegraph
sshcode kyle@dev.kwc.io "~/projects/sourcegraph"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be quoted on all OSes, thank you.

README.md Outdated Show resolved Hide resolved
@sreya sreya merged commit 46ef157 into coder:master May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants