Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete resources & data sources if not found #102

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 16, 2024

Closes #100.

Hashicorp's own providers only do this deletion if the resource can't be found during Read, and not during Update, so we'll do the same.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson force-pushed the 09-16-fix_delete_resources_data_sources_if_not_found branch from 8e299b2 to c434450 Compare September 16, 2024 14:33
@ethanndickson ethanndickson marked this pull request as ready for review September 16, 2024 14:33
@ethanndickson ethanndickson self-assigned this Sep 17, 2024
@ethanndickson ethanndickson merged commit 4165f6e into main Sep 17, 2024
14 checks passed
@ethanndickson ethanndickson deleted the 09-16-fix_delete_resources_data_sources_if_not_found branch September 17, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes outside of terraform result in an erroring terraform plan
2 participants