feat: add template max port sharing level attribute #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson
force-pushed
the
09-30-feat_add_template_max_port_sharing_level_attribute
branch
2 times, most recently
from
bc9fa48 to
92e865b
Compare
ethanndickson
force-pushed
the
09-30-feat_add_template_max_port_sharing_level_attribute
branch
from
92e865b to
dcf7db0
Compare
deansheather
approved these changes
Sep 30, 2024
ethanndickson
deleted the
09-30-feat_add_template_max_port_sharing_level_attribute
branch
ethanndickson
added a commit
that referenced
this pull request
Feb 26, 2025
… is default (#190) Closes #188. For context, the `MaxPortShareLevel` template metadata value was not present on the `coderd` create template request prior to 2.15. As such, during template creation we need to send an update request for backwards compatibility (though we could probably remove this soon), see #110. Whilst we don't send this update request is the attribute is omitted on the resource, we were sending a spurious update request if the value was explicitly configured to the default value ('owner' for enterprise+, 'public' otherwise). This was causing the error in the linked issue. An example is seen in the newly added test. The fix is to just not send that update request if the configured value is: - Unknown - Equal to the value on the newly created template. note: I'd recommend hiding the whitespace when reviewing the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat hacky, temporary, solution to #108.
Prior to Coder
v2.15.0(via coder/coder#14366), it was not possible to set the max port sharing level when the template was created. To retain compatibility between the template resource and older, supported, versions of Coder, the provider will make aPATCHrequest immediately after creating the template to set the max port sharing level.When we no longer support versions of Coder prior to
v2.15.0, we'll remove the redundant update request.