-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add organization resource #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've got a bunch of boilerplate up on #49, feel free to steal and I'll close that PR. The test boilerplate and the member crud are probably the most useful |
oh rad! thank you, I hadn't noticed that PR! |
I filled out the meat of this PR using your other branch as a reference. I'll work on the tests tomorrow–again basing off of your branch, but I want to try to use the |
I've removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I need to learn some of these terraform provider libs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
var org codersdk.Organization | ||
var err error | ||
if data.ID.IsNull() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your import test supplies a UUID into the name field, but Organization
and OrganizationByName
call the same endpoint, so I believe supporting imports by name will always allow you to import by ID? Hence why the import test is passing when it shouldn't. Setting the attributes at the bottom corrects the issue where the name is temporarily the UUID, so I don't think it's bug prone.
No description provided.