Skip to content

Removed connection status indicator? #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ammario opened this issue Sep 23, 2024 · 4 comments
Closed

Removed connection status indicator? #361

ammario opened this issue Sep 23, 2024 · 4 comments
Assignees
@ethanndickson
Labels
good first issue Good for newcomers regression Something that used to work and is now broken

Comments

@ammario
Copy link
Member

ammario commented Sep 23, 2024

I'm on the latest extension and noticed that we removed the connections status indicator at some point.

I found it helpful, in particular, to know whether the connection is P2P and, if not, which DERP region I'm connecting through. It would also be nice to see an estimate of end-to-end latency. In general I have noticed a decay in responsiveness in my VS Code - Coder experience and I'd like to get to the bottom of it.

image
@redartera
Copy link

Been having the same issue - it's normally very useful for me to keep track of latency and P2P/Relay connection status

@matifali
Copy link
Member

matifali commented Mar 6, 2025 •
edited
Loading

I too have the same issue and have not seen the connection indicator for the last few months. I don't remember when and why we removed it.

Any clues @bcpeinhardt and @code-asher ?

@code-asher
Copy link
Member

code-asher commented Mar 6, 2025 •
edited
Loading

I think we do some janky overriding of the indicator, maybe some internal API or behavior changed and now it no longer works.

@matifali matifali added regression Something that used to work and is now broken good first issue Good for newcomers labels Apr 3, 2025
@ethanndickson ethanndickson mentioned this issue Apr 15, 2025
Merged
@ethanndickson ethanndickson self-assigned this Apr 15, 2025
@matifali
Copy link
Member

Resolved in #480

@ethanndickson ethanndickson mentioned this issue May 1, 2025
Merged
ethanndickson added a commit that referenced this issue May 2, 2025
@ethanndickson
fix: add connection status indicator to vscode windows, windsurf, `op…
e7088ff 
…en-remote-ssh` (#492)

Relates to #361.

With the previous PR (Coder Connect integration), it's important that users always see this indicator, so I've added support in some extra scenarios. It already works in Cursor.

Windsurf (macOS):
<img width="1198" alt="image" src="https://github.com/user-attachments/assets/ab9b3ef4-5d70-436e-9503-f28734e446f6" />

VS Code (Windows):
![image](https://github.com/user-attachments/assets/6a322a1f-fa0f-4b75-b339-67a861550016)
I've been told Windows used to have the indicator, but they must have changed the format of this one log line to not have parity with the other platforms.

Windsurf (Windows):
![image](https://github.com/user-attachments/assets/195ff78a-2bab-402a-90a6-66d3d752ff09)

VSCodium - `jeanp413.open-remote-ssh` (Windows):
![image](https://github.com/user-attachments/assets/62efee16-a7d4-4419-ab89-e42163cc0e6d)

VSCodium - `jeanp413.open-remote-ssh` (macOS):
<img width="1196" alt="image" src="https://github.com/user-attachments/assets/a0da8eda-367b-42dd-99e9-861e580fee3b" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanndickson ethanndickson

Labels
good first issue Good for newcomers regression Something that used to work and is now broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ammario @matifali @ethanndickson @code-asher @redartera