Skip to content

feat: add VS code notifications for autostop #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: add VS code notifications for autostop #110

wants to merge 1 commit into from

Conversation

@Kira-Pilot
Copy link
Member

rodrimaia
rodrimaia approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I am just not sure if every 5 seconds is not too frequent to keep calling getWorkspaces

@Kira-Pilot
Copy link
Member Author

Approved. I am just not sure if every 5 seconds is not too frequent to keep calling getWorkspaces

Yeah, I feel the same way. It's the cadence we use in Dashboard so I went with it here.

@Kira-Pilot Kira-Pilot mentioned this pull request Jun 21, 2023
Merged
@Kira-Pilot
Copy link
Member Author

Closing in favor of #111

@Kira-Pilot Kira-Pilot closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

1 more reviewer

@rodrimaia rodrimaia rodrimaia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kira-Pilot @rodrimaia