Skip to content

Fix "undefined" in error message #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix "undefined" in error message #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ export class Commands {
return undefined
})
.catch((err) => {
let message = err
if (axios.isAxiosError(err) && err.response?.data) {
message = err.response.data.detail
}
if (err instanceof CertificateError) {
err.showNotification()

Expand All @@ -72,6 +68,8 @@ export class Commands {
}
// This could be something like the header command erroring or an
// invalid session token.
const message =
err?.response?.data?.detail || err?.message || err?.response?.status || "no response from the server"
return {
message: "Failed to authenticate: " + message,
severity: vscode.InputBoxValidationSeverity.Error,
Expand Down