Skip to content

Conversation

@EhabY
Copy link
Collaborator

@EhabY EhabY commented Nov 18, 2025

Closes #575

@mtojek mtojek requested review from jakehwll and mtojek November 18, 2025 18:33
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against the file locking implementation used here, but asking out of curiosity: would IPC communication between VS Code windows have been an option here, like with the login prompt?

Thanks for working on this ❤️, concurrent downloads has been a pain-point for me!

@EhabY
Copy link
Collaborator Author

EhabY commented Nov 20, 2025

would IPC communication between VS Code windows have been an option here, like with the login prompt?

@mafredri We could maybe use this for the progress monitoring but we definitely need a lock file since that would make crashes/staleness/stuck handling much simpler. Libraries like proper-filelock are already implemented to handle this. IPC communication using secrets might get a bit tricky and cumbersome to work with. Also, we already writing the binary to the file system, it only feels natural to use a filelock in the same folder 😉

@EhabY EhabY force-pushed the concurrent-binary-download-lockfile-fix branch from 6d67d87 to f6d76c8 Compare November 21, 2025 08:12
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments! As long as other reviewers approve, you're good to go 👍

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, thanks for amending/answering my comments 👍🏻

@EhabY EhabY merged commit 9ef38a3 into coder:main Nov 25, 2025
3 checks passed
@EhabY EhabY mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing error message: "Failed to read signature or binary"

4 participants