-
Notifications
You must be signed in to change notification settings - Fork 35
Refactor SSH process monitoring to support VS Code forks #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SSH process monitoring to support VS Code forks #665
Conversation
1797956 to
68fa375
Compare
e20c456 to
e7f92b2
Compare
mafredri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major issues spotted, nice refactor 👍🏻 (albeit a bit much TS for me today 😂)
jakehwll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy from a Typescript-side of things 🙂 Once @mafredri's comments are resolved LGTM
mafredri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
dedicated SshProcessMonitor class. Add centralized Remote SSH extension detection to better support Cursor, Windsurf, and other VS Code forks. Key changes: - Extract SSH monitoring logic from remote.ts into sshProcess.ts - Add sshExtension.ts to detect installed Remote SSH extension - Use createRequire instead of private module._load API - Fix port detection to find most recent port (handles reconnects) - Add Cursor's "Socks port:" log format to port regex
cf63417 to
4bec022
Compare
aecf3a9 to
081819e
Compare
Extract SSH process discovery and network status display into a
dedicated
SshProcessMonitorclass. Add centralized Remote SSH extensiondetection to support Cursor, Windsurf, and other VS Code forks.
Key changes:
remote.tsintosshProcess.tssshExtension.tsto detect installed Remote SSH extensioncreateRequireinstead of privatemodule._loadAPI to load the Remote SSH extensionCloses #660