Skip to content

Conversation

@EhabY
Copy link
Collaborator

@EhabY EhabY commented Dec 1, 2025

Extract SSH process discovery and network status display into a
dedicated SshProcessMonitor class. Add centralized Remote SSH extension
detection to support Cursor, Windsurf, and other VS Code forks.

Key changes:

  • Extract SSH monitoring logic from remote.ts into sshProcess.ts
  • Add sshExtension.ts to detect installed Remote SSH extension
  • Use createRequire instead of private module._load API to load the Remote SSH extension
  • Fix port detection to find most recent port (handles reconnects)
  • Add Cursor's "Socks port:" log format to port regex

Closes #660

@EhabY EhabY force-pushed the fix-log-file-finding-for-non-ms-vs-code branch 2 times, most recently from 1797956 to 68fa375 Compare December 1, 2025 19:51
@EhabY EhabY changed the title Fix log file finding for non ms vs code Refactor SSH process monitoring to support VS Code forks Dec 2, 2025
@EhabY EhabY requested review from jakehwll and mafredri December 2, 2025 14:24
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues spotted, nice refactor 👍🏻 (albeit a bit much TS for me today 😂)

Copy link

@jakehwll jakehwll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy from a Typescript-side of things 🙂 Once @mafredri's comments are resolved LGTM

@EhabY EhabY requested a review from mafredri December 5, 2025 09:37
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

EhabY added 3 commits December 8, 2025 11:04
dedicated SshProcessMonitor class. Add centralized Remote SSH extension
detection to better support Cursor, Windsurf, and other VS Code forks.

Key changes:
- Extract SSH monitoring logic from remote.ts into sshProcess.ts
- Add sshExtension.ts to detect installed Remote SSH extension
- Use createRequire instead of private module._load API
- Fix port detection to find most recent port (handles reconnects)
- Add Cursor's "Socks port:" log format to port regex
@EhabY EhabY force-pushed the fix-log-file-finding-for-non-ms-vs-code branch from cf63417 to 4bec022 Compare December 8, 2025 08:07
@EhabY EhabY force-pushed the fix-log-file-finding-for-non-ms-vs-code branch from aecf3a9 to 081819e Compare December 8, 2025 09:16
@EhabY EhabY merged commit aad1920 into coder:main Dec 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coder: View Logs does not work on non-MS VS Code IDEs

3 participants