Skip to content

feat: Add extension settings for customizing ssh config #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 31, 2023
Merged

feat: Add extension settings for customizing ssh config #74

merged 9 commits into from
Mar 31, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 29, 2023 •
edited
Loading

Allow users to override the default SSH config options, just like the coder cli allows with flags. This affects what is written to ~/.ssh/config.

Screenshot from 2023-03-29 12-47-57

@Emyrk Emyrk marked this pull request as ready for review March 29, 2023 17:48
@Emyrk Emyrk requested a review from kylecarbs March 29, 2023 17:48
@Emyrk Emyrk requested a review from rodrimaia March 30, 2023 13:48
rodrimaia
rodrimaia approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@Emyrk Emyrk merged commit 3e9cfec into main Mar 31, 2023
@Emyrk Emyrk deleted the stevenmasley/extension_settings branch March 31, 2023 13:47
@Emyrk Emyrk mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrimaia rodrimaia rodrimaia approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @rodrimaia