Skip to content

feat: show agent metadata #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2023
Merged

feat: show agent metadata #92

merged 7 commits into from
May 9, 2023

Conversation

rodrimaia
Copy link
Contributor

@rodrimaia rodrimaia commented May 2, 2023

the UI alignment is not working as it is supposed to, I guess something related to the vscode tooltip internals (because the string itself is correct). I can investigate this later, but I don't think that is a blocker.

  • We added the metadata to the sidebar instead of having a statusbaricon:
    image

Closes #71

@matifali
Copy link
Member

matifali commented May 3, 2023

Wow loved it. Awesome addition.

@matifali matifali self-requested a review May 3, 2023 16:16
@kylecarbs
Copy link
Member

@rodrimaia the agent name is already shown in the workspace title, so I'm not sure we should add another item to the bottom bar all the time.

e.g. if I have no metadata right now, what shows up?

Copy link
Contributor

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. My only considerations are:

  • What happens if it is empty or the agent is not connected
  • If there is no way to align the value text to the right, I'm ok with this version

@rodrimaia
Copy link
Contributor Author

  • Hide/Close the statusbar icon if there is no metadata
  • icon name changed to "Metadata"

@kylecarbs
Copy link
Member

@rodrimaia could you update the screenshot with the new display?

@rodrimaia
Copy link
Contributor Author

@rodrimaia could you update the screenshot with the new display?

@kylecarbs
image

@kylecarbs
Copy link
Member

@rodrimaia thoughts on putting metadata in the Coder sidebar instead?

@kylecarbs
Copy link
Member

The reason is that it's kinda odd for dynamic data to go in the tooltip, and in the UI we have a "Copy" button, which might be useful in the extension too.

@rodrimaia
Copy link
Contributor Author

@kylecarbs I am experimenting with showing the metadata on the sidebar. I will post it here when I reach a working version.

@rodrimaia
Copy link
Contributor Author

image

@rodrimaia rodrimaia merged commit 0e76e62 into main May 9, 2023
@rodrimaia rodrimaia deleted the show-agent-metadata branch May 9, 2023 18:46
@rodrimaia rodrimaia self-assigned this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display agent metadata
4 participants