Skip to content

add coder to the Open a Remote Window list #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

rodrimaia
Copy link
Contributor

Closes #93

We added Coder actions to the "Open a Remote Window" menu list.

image

@rodrimaia rodrimaia requested a review from matifali May 9, 2023 20:36
@rodrimaia rodrimaia self-assigned this May 9, 2023
@@ -106,7 +106,9 @@ class AgentMetadataTreeItem extends vscode.TreeItem {
metadataEvent.description.display_name.trim() + ": " + metadataEvent.result.value.replace(/\n/g, "").trim()

super(label, vscode.TreeItemCollapsibleState.None)
this.tooltip = "Collected at " + metadataEvent.result.collected_at
const collected_at = new Date(metadataEvent.result.collected_at).toLocaleString()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squeezing this in 😄 to improve sidebar metadata tooltip

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should remove the preceding Coder from
Coder: Open Workspace --> Open Workspace
To make it consistent wit other options in the list

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can address the comment, except that it all looks perfect.

@rodrimaia
Copy link
Contributor Author

Maybe you should remove the preceding Coder from Coder: Open Workspace --> Open Workspace To make it consistent wit other options in the list

Nice! Done! :)

@rodrimaia rodrimaia merged commit 5854315 into main May 10, 2023
@rodrimaia rodrimaia deleted the add-to-remote-list branch May 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the Coder workspaces here in this list? Or at least an option to list the workspaces?
2 participants