Add http proxy support to extension host #36
Conversation
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
Looks great! No concerns just one clarifying question.
| * @author coder | ||
| */ | ||
| export async function monkeyPatchHttpAgent(): Promise<void> { | ||
| if (process.env.http_proxy || process.env.https_proxy || process.env.HTTP_PROXY || process.env.HTTPS_PROXY) { |
There was a problem hiding this comment.
Do we need to add no_proxy as an option?
There was a problem hiding this comment.
Nope, no_proxy is for specifying exceptions; the proxy agent module will check no_proxy when making a request to see whether it should send through the proxy or not.
If http_proxy and friends are not set then no_proxy has no effect.
|
Uh...apparently this already works. I removed my changes to confirm but everything works exactly the same. I cannot seem to find how they are doing this so I am not sure if I am just doing something dumb like not properly recompiling. |
Lol out of curiosity, how are you testing this? |
|
i am running https://github.com/coder/vscode-coder since it makes a download request to fetch the Coder CLI. Then I run |
|
I confirmed it works in the latest artifact built by CI...I still have not located where this happens but I guess for now we are good to move on.
|
|
Nice thorough testing! Well, I'll leave that issue in code-server open and move it to the next version milestone then! |
2 participants
For coder/code-server#4672
I tested it with our extension (which downloads the Coder CLI) and confirmed it works. Once I finish my test extension PR I will add a test for the proxy there as well.